mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53605: Added --seccomp_profile flag to Mesos agent.
Date Mon, 28 Nov 2016 17:59:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53605/#review157072
-----------------------------------------------------------




src/slave/flags.cpp (lines 524 - 526)
<https://reviews.apache.org/r/53605/#comment227486>

    Would you add a simple example like `allowed_capabilities`?
    
    I am also not sure if `seccomp_profile` is a clear name here.


- haosdent huang


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53605/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
>     https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Operator uses this flag to pass in JSON file that specifies a set of
> Seccomp rules that will be enforced on all container processes launched
> on this agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 7824407a6bbfc06edeec69479ed82cabae34a440 
>   src/common/parse.hpp 1dca9ba4ed4ff2163193ab6432b5b017d2be787e 
>   src/common/type_utils.cpp 8270f808277d84a73823992c639d6536a99353b8 
>   src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
> 
> Diff: https://reviews.apache.org/r/53605/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message