mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52868: Health checks may be stopped on demand.
Date Fri, 25 Nov 2016 11:51:53 GMT


> On Nov. 24, 2016, 5:25 p.m., Gastón Kleiman wrote:
> > I think that `HealthChecker::stop()` should just terminate the actor, no need to
introduce a boolean.

Good idea. WILCO.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52868/#review156861
-----------------------------------------------------------


On Nov. 25, 2016, 11:50 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52868/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 11:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.
> 
> 
> Bugs: MESOS-5963
>     https://issues.apache.org/jira/browse/MESOS-5963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp 837d1358e418d21536da488e4a23cbfa41db6060 
>   src/health-check/health_checker.cpp af5500be249c74a4a5e64bf38dea607173e2f998 
> 
> Diff: https://reviews.apache.org/r/52868/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message