mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53704: Added a level of indirection for logger through an IO Switchboard.
Date Thu, 24 Nov 2016 16:29:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53704/
-----------------------------------------------------------

(Updated Nov. 24, 2016, 4:29 p.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Rebased on master to accommodate addition of `user` parameter to `logger->parpare()`


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

The purpose of this component is to feed stdin to a container from an
external source, as well as redirect the stdin/stdout of a container
to multiple targets.

In this commit, we simply add the IOSwitchboard as a component that
interposes on the fds set up to communicate between the logger and a
container.

In the future, we will expand this component to (optionaly) launch a
sidecar HTTP server process which will be responsible for handling
'ATTACH_CONTAINER_INPUT' and 'ATTACH_CONTAINER_OUTPUT' calls on behalf
of a container to redirect the stdin/stdout/sderr of a container to
external clients.


Diffs (updated)
-----

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 
  src/slave/containerizer/mesos/containerizer.hpp c8d43f918981d06a73662cf1be61081915816ca5

  src/slave/containerizer/mesos/containerizer.cpp d9e6bb4e4d62e6aa542c0bc7e9a5e0c6dcc670e5

  src/slave/containerizer/mesos/io/switchboard.hpp PRE-CREATION 
  src/slave/containerizer/mesos/io/switchboard.cpp PRE-CREATION 
  src/tests/containerizer/docker_volume_isolator_tests.cpp c369b313b5ed375cc8790c4f6e5cc22f6f9095c1

  src/tests/containerizer/mesos_containerizer_tests.cpp fa773c8badf4ddca11b5dfe8033b5ffb16dba213


Diff: https://reviews.apache.org/r/53704/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message