mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53938: Added helper to get the io switchboard server address.
Date Thu, 24 Nov 2016 05:07:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53938/
-----------------------------------------------------------

(Updated Nov. 24, 2016, 5:07 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Updated to get the socket address from a file checkpointed in the container runtime directory.
A subseqnet commit will do the checkpointing of this file to this directory with the proper
socket address.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

For now, the io switchboard server will always hosted on a unix domain
socket. The path limit for a unix domain socket is 100 bytes, so we
can't just use a file in our runtime directory as the socket file we
connect to. Instead, we store the path to the socket file in our
runtime directory and read it from there.


Diffs (updated)
-----

  src/slave/containerizer/mesos/paths.hpp 883cc263c58cf24c3e515dad7bda97efd32f2f17 
  src/slave/containerizer/mesos/paths.cpp 361307f21422c046672fb7ed29add8fe7e5c4354 

Diff: https://reviews.apache.org/r/53938/diff/


Testing
-------

make


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message