mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53938: Added helper to get the io switchboard server address.
Date Wed, 23 Nov 2016 23:17:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53938/#review156799
-----------------------------------------------------------




src/slave/containerizer/mesos/utils.cpp (line 68)
<https://reviews.apache.org/r/53938/#comment227097>

    This does not sound right. What about nested containers? See my comments in the following
patch. We should consider save a symlink in runtime dir and use a temp dir for the actual
socket file.


- Jie Yu


On Nov. 23, 2016, 2:45 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53938/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 2:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6467
>     https://issues.apache.org/jira/browse/MESOS-6467
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For now, the io switchboard server will always hosted on a unix domain
> socket. The path limit for a unix domain socket is 100 bytes, so we
> can't just use a file in our runtime directory as the socket file we
> connect to. Instead, we store the path to the socket file in our
> runtime directory and read it from there.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9 
>   src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710 
> 
> Diff: https://reviews.apache.org/r/53938/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message