mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52190: Removed deprecated compiler warnings.
Date Wed, 23 Nov 2016 21:27:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/#review156785
-----------------------------------------------------------




cmake/CompilationConfigure.cmake (lines 97 - 98)
<https://reviews.apache.org/r/52190/#comment227075>

    Can you add some comments above these?
    
    I presume that the first definition silences some MSVC or CRT warnings.  But what does
the second definition do?


- Joseph Wu


On Nov. 23, 2016, 9:12 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52190/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed deprecated compiler warnings.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 
> 
> Diff: https://reviews.apache.org/r/52190/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message