mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 54007: Printed complete health check configuration on task launch.
Date Wed, 23 Nov 2016 08:56:07 GMT


> On Nov. 23, 2016, 4:10 a.m., haosdent huang wrote:
> > src/health-check/health_checker.cpp, line 213
> > <https://reviews.apache.org/r/54007/diff/2/?file=1568839#file1568839line213>
> >
> >     No sure if `check.SerializeAsString()` would be better or not. Or we could add
a `stringify()` for protobuf message?

hmm, realize the output of `check.SerializeAsString()` is not a json string.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54007/#review156700
-----------------------------------------------------------


On Nov. 23, 2016, 1:11 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54007/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.cpp af5500be249c74a4a5e64bf38dea607173e2f998 
> 
> Diff: https://reviews.apache.org/r/54007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message