mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53704: Added a level of indirection for logger through an IO Switchboard.
Date Wed, 23 Nov 2016 02:40:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53704/
-----------------------------------------------------------

(Updated Nov. 23, 2016, 2:40 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Addressed all of Jie's comments.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

The purpose of this component is to feed stdin to a container from an
external source, as well as redirect the stdin/stdout of a container
to multiple targets.

In this commit, we simply add the IOSwitchboard as a component that
interposes on the fds set up to communicate between the logger and a
container.

In the future, we will expand this component to (optionaly) launch a
sidecar HTTP server process which will be responsible for handling
'ATTACH_CONTAINER_INPUT' and 'ATTACH_CONTAINER_OUTPUT' calls on behalf
of a container to redirect the stdin/stdout/sderr of a container to
external clients.


Diffs (updated)
-----

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 
  src/slave/containerizer/mesos/containerizer.hpp c8d43f918981d06a73662cf1be61081915816ca5

  src/slave/containerizer/mesos/containerizer.cpp e47a120bfbb607cc0cdbdaed934ae15f15666ae3

  src/slave/containerizer/mesos/io/switchboard.hpp PRE-CREATION 
  src/slave/containerizer/mesos/io/switchboard.cpp PRE-CREATION 
  src/tests/containerizer/docker_volume_isolator_tests.cpp 2f21b49535856186e153cd299dd1eda11495fa17

  src/tests/containerizer/mesos_containerizer_tests.cpp 5aae23b1b470d5323ecc21fb5df7ad8ae2498dfa


Diff: https://reviews.apache.org/r/53704/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message