mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.
Date Wed, 23 Nov 2016 00:25:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53802/#review156652
-----------------------------------------------------------




3rdparty/libprocess/src/libevent_ssl_socket.cpp (lines 246 - 248)
<https://reviews.apache.org/r/53802/#comment226846>

    We should probably amend this comment block with another section to explain the EOF bool.
    Same with the last line of this diff.



3rdparty/libprocess/src/libevent_ssl_socket.cpp (lines 406 - 410)
<https://reviews.apache.org/r/53802/#comment226862>

    I'm wondering if separating out this critical section into several chunks will introduce
any bugs.
    
    It may be worthwhile to move each of the three swaps into their associated `if-statement`.


- Joseph Wu


On Nov. 22, 2016, 11:55 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53802/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 11:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5966
>     https://issues.apache.org/jira/browse/MESOS-5966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, it was possible for an SSL socket to either:
> 1) Fail to receive an EOF if the EOF event was received when
>    there was no pending recv() request.
> 2) Fail to receive all data sent on the sending side if an
>    EOF event was received before all sent data was read.
>  	
> This patch eliminates these race conditions to ensure reliable
> receipt of both sent data and EOFs.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.hpp acb00d41c637a318b2f16fff9e97998b9c79b809

>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 21f878ee81db32ad35878ec053c3f2de3637196c

> 
> Diff: https://reviews.apache.org/r/53802/diff/
> 
> 
> Testing
> -------
> 
> Testing details are found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message