mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53975: Moved server socket deletion in 'process::finalize()'.
Date Tue, 22 Nov 2016 21:44:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53975/#review156645
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Nov. 21, 2016, 10:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53975/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5966
>     https://issues.apache.org/jira/browse/MESOS-5966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need to destroy the server socket and discard its
> future before we finalize the process manager
> because the socket's `onDiscard` callback may need to
> run in the event loop, but process manager
> finalization stops the event loop.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 
> 
> Diff: https://reviews.apache.org/r/53975/diff/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message