mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Review Request 53975: Moved server socket deletion in 'process::finalize()'.
Date Tue, 22 Nov 2016 06:53:49 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Mahler and Joseph Wu.

Bugs: MESOS-5966

Repository: mesos


We need to destroy the server socket and discard its
future before we finalize the process manager
because the socket's `onDiscard` callback may need to
run in the event loop, but process manager
finalization stops the event loop.


  3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 



Testing details at the end of this review chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message