mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53754: CMake: Added test modules that are loaded by mesos tests.
Date Mon, 21 Nov 2016 22:13:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53754/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 2:13 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
-------

Alphabetized the example module properly.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

Builds shared libraries that are dynamically loaded in the
module tests.  These are excluded on Windows, which only
supports static libraries.

This review replaces: https://reviews.apache.org/r/49863/


Diffs (updated)
-----

  CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/53754/diff/


Testing
-------

cmake ..
make


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message