mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53761: CMake: Add a target between MESOS_TARGET and MESOS_PROTOBUFs.
Date Mon, 21 Nov 2016 19:27:35 GMT


> On Nov. 17, 2016, 9:13 a.m., Alex Clemmer wrote:
> > cmake/MesosConfigure.cmake, line 145
> > <https://reviews.apache.org/r/53761/diff/1/?file=1563897#file1563897line145>
> >
> >     Hmm, can you explain the decision to add `ALL` here? It's not clear to me what
the implications are.

The keyword `ALL` tells CMake to add a custom target to the list of targets built when you
run `make` (or equivalent).

For example, our custom target for `make check` does not use the `ALL` keyword because running
the tests are opt-in only.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53761/#review156215
-----------------------------------------------------------


On Nov. 14, 2016, 7:11 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53761/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need this extra level of targets in order to model the
> dependency chain for binaries and libraries.  An example
> is the mesos-containerizer binary, which depends on libmesos
> (i.e. MESOS_TARGET) but does not get included in the dependency
> chain if you only depend on MESOS_TARGET.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
> 
> Diff: https://reviews.apache.org/r/53761/diff/
> 
> 
> Testing
> -------
> 
> See next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message