mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.
Date Mon, 21 Nov 2016 19:25:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53487/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 7:25 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Review comments


Bugs: MESOS-6466
    https://issues.apache.org/jira/browse/MESOS-6466


Repository: mesos


Description (updated)
-------

Old libprocess style messages and routes not supporting request
streaming read the body from the piped reader. Otherwise, the
request is forwarded to the handler when the route supports
streaming.

Review: https://reviews.apache.org/r/53487/


Diffs (updated)
-----

  3rdparty/libprocess/include/process/process.hpp f389d3d3b671e301a7ac911ad87ab13289e8c82f

  3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 

Diff: https://reviews.apache.org/r/53487/diff/


Testing
-------

make check (Tests are added in https://reviews.apache.org/r/53490 i.e., after we add support
to the `Connection` abstraction for request streaming)


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message