mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <>
Subject Re: Review Request 53837: Added a per container io switchboard server process.
Date Sun, 20 Nov 2016 23:02:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 20, 2016, 11:02 p.m.)

Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Updated to use the helper for obtaining the io switchboard server address in the container
runtime directory. Also changed the return value for the stub HTTP handler to return `BadRequest()`
instead of `OK()` for now.

Bugs: MESOS-6467

Repository: mesos


Currently, this process simply intercepts the stdout/stderr of a
container and writes it to the stdout/stderr FDs set up by the
container logger. We also send the stdout/stderr data to a simple HTTP
server that we launch on a unix domain socket set up by the agent.
Right now this server is just a stub and doesn't do anything useful.

In future commits, we will expand this HTTP server to handle
of a container. It will use the stdout/stderr messages passed to it to
and send that data over the response stream to any clients connected
with an 'ATTACH_CONTAINER_OUTPUT' call. Likewise, it will take any
input streamed in over a 'ATTACH_CONTAINER_INPUT' request and write it
to a container's stdin.

We don't currently handle recovering access to the io switchboard
server process after agent restarts. We will add that in a subsequent

Diffs (updated)

  src/ 5a47c93388234a68c3c486a021ccdbe3213c5bac 
  src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e

  src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp PRE-CREATION 
  src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp PRE-CREATION 
  src/slave/containerizer/mesos/io_switchboard/main.hpp PRE-CREATION 
  src/slave/containerizer/mesos/io_switchboard/main.cpp PRE-CREATION 



GTEST_FILTER="" make -j check
sudo src/mesos-tests


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message