mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.
Date Fri, 18 Nov 2016 18:09:06 GMT


> On Nov. 17, 2016, 9:47 p.m., Jiang Yan Xu wrote:
> > src/Makefile.am, line 1019
> > <https://reviews.apache.org/r/53790/diff/2/?file=1564516#file1564516line1019>
> >
> >     Keep the header file here?

I moved it because it makes no sense to specify files that are part of `mesos-tests` in the
`libmesos_no_3rdparty_la_SOURCES` variable. automake doesn't actually build header files,
but you still need to list them so they are included in the source distribution.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53790/#review156247
-----------------------------------------------------------


On Nov. 18, 2016, 6:08 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53790/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2016, 6:08 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6588
>     https://issues.apache.org/jira/browse/MESOS-6588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move containerizer Rootfs support to a cpp file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/containerizer/rootfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53790/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 24)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message