mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.
Date Fri, 18 Nov 2016 08:56:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review156286
-----------------------------------------------------------


Ship it!





src/health-check/health_checker.cpp (line 369)
<https://reviews.apache.org/r/52867/#comment226498>

    Still want these timeout variables?



src/health-check/health_checker.cpp (line 445)
<https://reviews.apache.org/r/52867/#comment226497>

    Still want these timeout variables?



src/health-check/health_checker.cpp (line 569)
<https://reviews.apache.org/r/52867/#comment226496>

    Still want these timeout variables?


- Benjamin Mahler


On Nov. 14, 2016, 10:28 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and Joseph
Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
>   src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message