mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.
Date Thu, 17 Nov 2016 21:47:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53790/#review156247
-----------------------------------------------------------


Fix it, then Ship it!




This patch is code movement only right? Would be more clear to state "no logical change" in
the summary.


src/Makefile.am 
<https://reviews.apache.org/r/53790/#comment226433>

    Keep the header file here?



src/tests/containerizer/rootfs.cpp (line 34)
<https://reviews.apache.org/r/53790/#comment226434>

    One line here.


- Jiang Yan Xu


On Nov. 15, 2016, 3:35 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53790/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6588
>     https://issues.apache.org/jira/browse/MESOS-6588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move containerizer Rootfs support to a cpp file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/containerizer/rootfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53790/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 24)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message