mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 53770: CMake Cleanup: Alphabetize the list of sources.
Date Tue, 15 Nov 2016 03:23:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53770/
-----------------------------------------------------------

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

This alphabetizes the sources by variable name, and then by filename.
A few missing files were added and some duplicate files were removed.


Diffs
-----

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 

Diff: https://reviews.apache.org/r/53770/diff/


Testing
-------

This being the final review in the chain, I ran the cmake build on several systems:

cmake ..
make check (OSX)
make check (CentOS 7)

sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7)

These have reached parity with the automake build configured with `--disable-java --disable-python`.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message