mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52864: Removed unnecessary sleep in HealthChecker.
Date Mon, 14 Nov 2016 10:24:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52864/
-----------------------------------------------------------

(Updated Nov. 14, 2016, 10:24 a.m.)


Review request for mesos, Gastón Kleiman and haosdent huang.


Repository: mesos


Description
-------

After we have refactored the HealthChecker into a library from the
binary, there is no more need to wait before failing the promise to
ensure the message has been sent to the executor. HealthChecker
lifetime is managed by an executor, hence it is their responsibility
not to clean the instance until after the message with the `kill_task`
flag is received.


Diffs (updated)
-----

  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52864/diff/


Testing
-------

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message