mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Review Request 53700: Refactored `group` in LogProcess into ZooKeeperPIDGroup.
Date Mon, 14 Nov 2016 03:39:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53700/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Bugs: MESOS-5828
    https://issues.apache.org/jira/browse/MESOS-5828


Repository: mesos


Description
-------

LogProcess and ZooKeeperPIDGroup held a zookeeper::Group object
respectively, former one for renewing this replica's own membership
and the latter one for observing memberships of other replicas.
Both of the group objects are intended to maintain a set of PIDs for
replicated log to operate properly.

`group` in LogProcess is refactored into ZooKeeperPIDGroup class,
which is more cohesive and decoupled with LogProcess. This made
the interface between these two classes cleaner. This is also a step
towards modularizing PIDGroup alongside master contender and detector.


Diffs
-----

  src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
  src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
  src/log/pid_group/zookeeper.hpp PRE-CREATION 
  src/log/pid_group/zookeeper.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/53700/diff/


Testing
-------


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message