mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <>
Subject Re: Review Request 50493: Added `base` to PIDGroup.
Date Mon, 14 Nov 2016 03:33:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 14, 2016, 3:33 a.m.)

Review request for mesos and Joseph Wu.


rebase and addressed some of Joseph's comments.

Bugs: MESOS-5828

Repository: mesos


All subclasses derived from PIDGroup are required to have `base`
as a set of PIDs that always exist from the beginning. Therefore
`base` is refactored into PIDGroup base class. This is a step
towards modularizing replicated_log's PIDGroup abstraction.

Diffs (updated)

  3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
  3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 



see end of review chain


Jay Guo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message