mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 50491: Added PIDGroup to libprocess.
Date Mon, 14 Nov 2016 03:32:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50491/
-----------------------------------------------------------

(Updated Nov. 14, 2016, 3:32 a.m.)


Review request for mesos and Joseph Wu.


Changes
-------

rebase


Bugs: MESOS-5828
    https://issues.apache.org/jira/browse/MESOS-5828


Repository: mesos


Description
-------

Log network is not specific to replicated log and the name 'network'
is also confusing. Therefore, PIDGroup is added to libprocess as a
replacement for network. This is a step towards modularizing the
PIDGroup abstraction alongside the `MasterContender` and
`MasterDetector`.

Note: The PIDGroup abstraction is a component that discovers all masters
in the group; whereas the `MasterDetector` only discovers the leader
of the group. Both are necessary for the replicated log.


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 71319891a451bd1d565210dcce2fb61fc69e1f61 
  3rdparty/libprocess/include/Makefile.am 17c5d11463d0fa16f7039e8395146a62e38deece 
  3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
  3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/pid_group_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50491/diff/


Testing
-------

see the end of review chain.


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message