mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Review Request 53330: Add a pull timer for RegistryPuller.
Date Mon, 31 Oct 2016 23:44:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53330/
-----------------------------------------------------------

Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-6451
    https://issues.apache.org/jira/browse/MESOS-6451


Repository: mesos


Description
-------

Add a pull timer for RegistryPuller.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp b06ddff68a8d2df13abb838b03a8e73d4e273c31


Diff: https://reviews.apache.org/r/53330/diff/


Testing
-------

Use mesos-execute to pull several images, and verified following counters in agent's metrics/snapshot:
```
curl localhost:5051/metrics/snapshot | jq . | grep containerizer/mesos/docker_pull
  "containerizer/mesos/docker_pull_ms/p9999": 12181.1797626368,
  "containerizer/mesos/docker_pull_ms/p99": 12159.39527168,
  "containerizer/mesos/docker_pull_ms/p95": 12071.3771264,
  "containerizer/mesos/docker_pull_ms/p50": 11081.172992,
  "containerizer/mesos/docker_pull_ms": 11081.172992,
  "containerizer/mesos/docker_pull_ms/p90": 11961.3544448,
  "containerizer/mesos/docker_pull_ms/p999": 12179.199354368,
  "containerizer/mesos/docker_pull_ms/min": 3366.525952,
  "containerizer/mesos/docker_pull_ms/max": 12181.399808,
  "containerizer/mesos/docker_pull_ms/count": 3,
```


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message