mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53124: Add documentation on Windows support
Date Mon, 31 Oct 2016 21:10:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review154318
-----------------------------------------------------------



New docs should try to keep lines under 80 characters.

This can't be done in the case of URLs though, so you can leave those as is.

---

I added a bunch of suggestions and more details you can put in the doc.  You can probably
remove the `WIP` from your description in your next update.


docs/getting-started.md (line 29)
<https://reviews.apache.org/r/53124/#comment223809>

    Not yours, but can your correct the grammar on the first sentence to:
    ```
    The Mesos agent also runs
    ```
    
    And s/To build Mesos agent/To build Mesos/



docs/windows.md (line 63)
<https://reviews.apache.org/r/53124/#comment223811>

    s/Due to Windows/Due to the 260 character/
    ^ perhaps append a `on Windows` in the first part of the sentence, if it flows better.



docs/windows.md (lines 64 - 66)
<https://reviews.apache.org/r/53124/#comment223812>

    Indent by 2 spaces.



docs/windows.md (line 65)
<https://reviews.apache.org/r/53124/#comment223813>

    s/be as four/be up to/



docs/windows.md (line 68)
<https://reviews.apache.org/r/53124/#comment223814>

    This is almost entirely due to symlinks (i.e. in the sandbox directories, we symlink the
`ContainerID` to `latest`).  
    
    On Windows, this requires Admin... :(



docs/windows.md (lines 70 - 71)
<https://reviews.apache.org/r/53124/#comment223815>

    These three points (plus the `MesosContainerizer` point) are related.
    
    Isolation is not supported on the MesosContainerizer on Windows.  Depending on the APIs
Windows exposes for Windows Containers, this might be supported in future though...
    
    We will eventually support isolation via the DockerContainerizer (e.g. Windows Containers),
but only on specific Windows versions.


- Joseph Wu


On Oct. 29, 2016, 4:35 a.m., Lior Zeno wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2016, 4:35 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 69e8da5 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message