mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53227: Added the '--launcher_dir' flag to the default executor.
Date Mon, 31 Oct 2016 11:33:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53227/#review154244
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the outstanding issues and commit this for you shrotly.


src/launcher/default_executor.cpp (lines 99 - 100)
<https://reviews.apache.org/r/53227/#comment223737>

    Let's keep the order consistent, e.g. first sandbox, then launcherDir.



src/launcher/default_executor.cpp (lines 990 - 991)
<https://reviews.apache.org/r/53227/#comment223738>

    Same here.



src/launcher/default_executor.cpp (lines 1047 - 1055)
<https://reviews.apache.org/r/53227/#comment223739>

    Let's swap these two conditions.


- Alexander Rukletsov


On Oct. 27, 2016, 4:13 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53227/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-6288
>     https://issues.apache.org/jira/browse/MESOS-6288
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the '--launcher_dir' flag to the default executor.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 
>   src/slave/slave.cpp 881c10ac61d1e4fdeabdc42c0a41508c36f49040 
> 
> Diff: https://reviews.apache.org/r/53227/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message