mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53152: Added rlimit support to mesos-execute.
Date Mon, 31 Oct 2016 10:38:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53152/#review154242
-----------------------------------------------------------


Fix it, then Ship it!





src/cli/execute.cpp (line 233)
<https://reviews.apache.org/r/53152/#comment223735>

    Using a raw string literal here causes inclusion of e.g., all leading spaces in the help
text which leads to inconsistent indention in the rendered help text.
    
    I'd stick to manually escaped text here (instead of e.g., removing leading spaces in the
code).



src/cli/execute.cpp (lines 709 - 712)
<https://reviews.apache.org/r/53152/#comment223736>

    What's the order of enumeration here? IMHO we should either stick to alphabetical or alternatively
the order of parameters to `getContainerInfo`.


- Benjamin Bannier


On Oct. 25, 2016, 1:06 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53152/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 1:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added rlimit support to mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp e694853441c24cf17d8fd5a2ee1be17337458f67 
> 
> Diff: https://reviews.apache.org/r/53152/diff/
> 
> 
> Testing
> -------
> 
> `bin/mesos-execute --master=10.0.49.2:5050 --command="ulimit -a" --name=test --rlimits='{"rlimits":[{"type":"RLMT_NPROC"}]}'`
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message