mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.
Date Sun, 30 Oct 2016 03:14:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53084/#review154227
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/launcher/default_executor.cpp (line 1038)
<https://reviews.apache.org/r/53084/#comment223716>

    `if (value.isNone())` would be better?



src/scheduler/scheduler.cpp (lines 450 - 456)
<https://reviews.apache.org/r/53084/#comment223718>

    Would be better to keep the `TODO` location as same as above diff.



src/scheduler/scheduler.cpp (line 454)
<https://reviews.apache.org/r/53084/#comment223717>

    `if (value.isNone())` would be better?


- haosdent huang


On Oct. 28, 2016, 11:41 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53084/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2016, 11:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till Toenshoff,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6494
>     https://issues.apache.org/jira/browse/MESOS-6494
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `LIBPROCESS_SSL_ENABLED` is preferred over `SSL_ENABLED`, and the latter
> will be deprecated soon.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 
>   src/scheduler/scheduler.cpp e282d419119dd1f01e170acf5cc2c6175b59791d 
> 
> Diff: https://reviews.apache.org/r/53084/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message