mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.
Date Fri, 28 Oct 2016 21:18:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53266/#review154183
-----------------------------------------------------------



The diff is hard to review because in addition to making tests into fixture methods, there
seem to be movement of tests around? Am I understanding it correct? If yes, please do any
such moves in a different (dependent) review.

More importantly, can we just add ROOT_DOCKER prefix to all these tests instead? That way
these tests will only be run on machines with docker which is a bit unfortunate but not too
bad.

Alternatively, lets pick one test which we want to test with both the "mesos" and "docker,mesos"
containerizers. For all other tests just test with mesos containerizer. That way most tests
won't even need root privileges to be run and can be run in ASF CI.


src/tests/default_executor_tests.cpp (line 379)
<https://reviews.apache.org/r/53266/#comment223668>

    


- Vinod Kone


On Oct. 28, 2016, 6:27 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53266/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2016, 6:27 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6455
>     https://issues.apache.org/jira/browse/MESOS-6455
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some of the default executor tests use a parameterized value to choose
> which containerizers to use. This results in tests that require Docker,
> but don't contain "DOCKER_" in their names.
> 
> This patch uses fixtures instead of parameterized values for this tests,
> in order to be able to specify a custom name for the ones that use the
> Docker containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 70779e8d94fbb6e664cad4ddbfeb19e560176cfe 
> 
> Diff: https://reviews.apache.org/r/53266/diff/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.* --docker=/tmp/foo`
> `sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.*`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message