mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52840: Silenced a GMock warning in ROOT_DOCKER_DockerInspectDiscard.
Date Fri, 28 Oct 2016 11:50:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52840/#review154115
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Oct. 20, 2016, 9:31 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52840/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 9:31 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Silenced a GMock warning in ROOT_DOCKER_DockerInspectDiscard.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a

> 
> Diff: https://reviews.apache.org/r/52840/diff/
> 
> 
> Testing
> -------
> 
> Without this patch, `"sudo ./src/mesos-tests --gtest_filter="DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard"`
consistently results in:
> 
> ```
> [ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
> 
> GMOCK WARNING:
> Uninteresting mock function call - returning directly.
>     Function call: executorLost(0x7ffe1aad15e0, @0x7f2018000b00 e1, @0x7f2018000c30 0aec7dbf-3ce3-4d3a-a086-a95bd1e8dada-S0,
-1)
> Stack trace:
> [       OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (624 ms)
> ```
> 
> With this patch, running the test 100 times in a loop does not produce a warning.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message