mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <>
Subject Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags
Date Thu, 27 Oct 2016 16:51:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 27, 2016, 4:51 p.m.)

Review request for mesos, James Peach, Michael Park, and Neil Conway.


Addressed comments about the encoder changes.

Bugs: MESOS-6239

Repository: mesos


The hardening flags produced many new sign comparison errors in libprocess that need to be
fixed for Mesos to compile/run.

Diffs (updated)

  3rdparty/libprocess/src/decoder.hpp c79296b 
  3rdparty/libprocess/src/encoder.hpp 005d1cc 
  3rdparty/libprocess/src/process.cpp ab2b5a9 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 4535614 
  3rdparty/libprocess/src/tests/encoder_tests.cpp 9e57375 
  3rdparty/libprocess/src/tests/http_tests.cpp 533104c 
  3rdparty/libprocess/src/tests/io_tests.cpp b85c79f 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 0dc1c62 



Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran `make &&
make check && make bench`.


Aaron Wood

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message