mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Review Request 53202: Avoided CHECK failure with pre-1.0 agents.
Date Wed, 26 Oct 2016 19:51:43 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Vinod Kone and Jiang Yan Xu.

Bugs: MESOS-6483

Repository: mesos


We don't guarantee compatibility with pre-1.0 agents. However, since it
is easy to avoid a CHECK failure in the master when an old agent
re-registers, it seems worth doing so.


  src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31 



`make check`

Disabled the code that fills-in `frameworks.recovered`; verified that `PartitionTest.DisconnectedFramework`
dies with a `CHECK` failure if this RR is not applied but passes this with RR applied.


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message