mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' if pip-requirements.txt modified.
Date Tue, 25 Oct 2016 22:42:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53074/#review153832
-----------------------------------------------------------




support/mesos-style.py (line 297)
<https://reviews.apache.org/r/53074/#comment223317>

    Perhaps we should also check for modifications to the `mesos.bash_completion` file.  AFAICS,
these are the only two files that get used/copied while setting up the virtualenv.



support/mesos-style.py (lines 311 - 312)
<https://reviews.apache.org/r/53074/#comment223316>

    This effectively bypasses the virtualenv check you have inside the bootstrap script. 
But at this point in the script, the linter should not have entered the virtualenv yet.  Meaning
that the bootstrap script's check should still be run.


- Joseph Wu


On Oct. 20, 2016, 11:10 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53074/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 11:10 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6430
>     https://issues.apache.org/jira/browse/MESOS-6430
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated pylint to rebuild 'virtualenv' if pip-requirements.txt modified.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 3a5bec81950ccf8083cbd73577c49b2fb3b910f8 
> 
> Diff: https://reviews.apache.org/r/53074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message