mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Review Request 53173: Removed flakiness from SlaveTest.KillTaskGroupBetweenRunTaskParts.
Date Tue, 25 Oct 2016 19:03:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53173/
-----------------------------------------------------------

Review request for mesos, Greg Mann and Vinod Kone.


Bugs: MESOS-6336
    https://issues.apache.org/jira/browse/MESOS-6336


Repository: mesos


Description
-------

The fakiness is due to the illegal memory access for pointer to struct
Framework in slave while  that pointer is already removed.
Without changing main design, this small patch can avoid the illegal
memory access.


Diffs
-----

  src/slave/slave.cpp 881c10ac61d1e4fdeabdc42c0a41508c36f49040 

Diff: https://reviews.apache.org/r/53173/diff/


Testing
-------

On both Red Hat Enterprise Linux Server 7.2 and Ubuntu 16.04:
GTEST_FILTER="SlaveTest.KillTaskGroupBetweenRunTaskParts" make -j`nproc` check
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="SlaveTest.KillTaskGroupBetweenRunTaskParts"
--verbose --gtest_repeat=1000 --gtest_break_on_failure


Thanks,

Abhishek Dasgupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message