mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.
Date Tue, 25 Oct 2016 03:42:34 GMT


> On Oct. 21, 2016, 4:19 p.m., James Peach wrote:
> > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 26
> > <https://reviews.apache.org/r/53041/diff/2/?file=1542972#file1542972line26>
> >
> >     FreeBSD would need a third branch for the (extattr)[https://www.freebsd.org/cgi/man.cgi?query=extattr&sektion=2&apropos=0&manpath=FreeBSD+10.3-RELEASE+and+Ports]
API. 
> >     
> >     It looks like stout does attempt to support FreeBSD.
> 
> Qian Zhang wrote:
>     Yes, FreeBSD also supports set/get extended attribute with a set of different interfaces
(e.g., `extattr_set_file`, `extattr_get_file`), but I think Mesos does not support FreeBSD
now, and such interface in FreeBSD is not stable yet, see the following info I got from the
manpage. So I would not suggest to support FreeBSD for extended attribute in `stout` at this
point.
>     ```
>     CAVEAT
>          This interface is under active development, and as such is subject to
>          change as applications are adapted to use it.  Developers are discouraged
>          from relying on its stability.
>     ```

Stout seems to support FreeBSD. If this API is not needed on the FreeBSD port right now, you
should return ``ENOSYS`` for FreeBSD.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53041/#review153556
-----------------------------------------------------------


On Oct. 25, 2016, 3:41 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53041/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
>     https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `setxattr()` and `getxattr()` in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am 1eb9c146d3eebacaea32e0f724d145f0c1dd676f 
>   3rdparty/stout/include/stout/os.hpp 96e8621b198a3ec4cce78e0a6ff5f271eda05ff1 
>   3rdparty/stout/include/stout/os/posix/xattr.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/xattr.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/xattr.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53041/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message