mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 53112: Fixed flakiness in `MasterTest.UnreachableTaskAfterFailover`.
Date Mon, 24 Oct 2016 22:35:29 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 24, 2016, 10:35 p.m.)

Review request for mesos and Vinod Kone.


Update description with more details.

Repository: mesos

Description (updated)

After launching a task, we need to wait for the slave to receive the
scheduler's ack of the initial TASK_RUNNING status update. If not, the
status update might be re-delivered after we restart the master, which
would break some test case expectations.

Also cleanup some test code along the way.

Diffs (updated)

  src/tests/master_tests.cpp 9963a0cb360f1e72c17c5a6e75bb88b17cdee467 



`make check`
`mesos-tests --gtest_filter=MasterTest.UnreachableTaskAfterFailover --gtest_repeat=1000 --gtest_break_on_failure`

Note that I couldn't repro the original test flakiness on my local machine, but from the log
(, this seems to be the problem.


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message