mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53112: Fixed flakiness in `MasterTest.UnreachableTaskAfterFailover`.
Date Mon, 24 Oct 2016 17:01:00 GMT


> On Oct. 24, 2016, 4:58 p.m., haosdent huang wrote:
> > Didn't you rebase before post the patch?

Whoops, my mistake -- thanks Haosdent, this should be fixed.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53112/#review153702
-----------------------------------------------------------


On Oct. 24, 2016, 5 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53112/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 5 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also cleanup some test code along the way.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 9963a0cb360f1e72c17c5a6e75bb88b17cdee467 
> 
> Diff: https://reviews.apache.org/r/53112/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> `mesos-tests --gtest_filter=MasterTest.UnreachableTaskAfterFailover --gtest_repeat=1000
--gtest_break_on_failure`
> 
> Note that I couldn't repro the original test flakiness on my local machine, but from
the log (https://builds.apache.org/job/mesos-reviewbot/15778), this seems to be the problem.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message