mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53033: Improved agent re-registration log messages.
Date Mon, 24 Oct 2016 15:45:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53033/
-----------------------------------------------------------

(Updated Oct. 24, 2016, 3:45 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address review comments.


Summary (updated)
-----------------

Improved agent re-registration log messages.


Repository: mesos


Description (updated)
-------

We should show the agent ID that we successfully re-registered with:
both for consistency with the log message upon initial registration, and
because this is useful information when debugging agent behavior. Tweak
other log messages to improve consistency.


Diffs (updated)
-----

  src/slave/slave.cpp 881c10ac61d1e4fdeabdc42c0a41508c36f49040 

Diff: https://reviews.apache.org/r/53033/diff/


Testing
-------

Visual inspection of revised log output.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message