mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 53053: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.
Date Mon, 24 Oct 2016 03:25:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/#review153655
-----------------------------------------------------------




src/slave/containerizer/mesos/utils.cpp (lines 25 - 38)
<https://reviews.apache.org/r/53053/#comment223071>

    Any specific reason this change is part of this patch? We should probably have a separate
patch for this change. Don't think it has anything to do with with whiteout conversion.
    
    Also, don't think we support nested containers on anything other than linux at this point


- Avinash sridharan


On Oct. 23, 2016, 3:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53053/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2016, 3:03 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
>     https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp e192f86a1848b373f3aa73d29688a96375cac313

>   src/slave/containerizer/mesos/utils.hpp 178ebf3effac824e4788d7282795c18dc1cb5265 
>   src/slave/containerizer/mesos/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53053/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message