mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53031: Failure in cleanup of non-existing cgroups is treated as success.
Date Sat, 22 Oct 2016 10:27:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53031/#review153640
-----------------------------------------------------------




src/linux/cgroups.cpp (lines 1624 - 1632)
<https://reviews.apache.org/r/53031/#comment223048>

    +1 For the changes. But I think we should log a warning log before mark it success when
find the directory not exist.


- haosdent huang


On Oct. 20, 2016, 6:20 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53031/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 6:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6414
>     https://issues.apache.org/jira/browse/MESOS-6414
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Failure in cleanup of non-existing cgroups is treated as success.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d 
> 
> Diff: https://reviews.apache.org/r/53031/diff/
> 
> 
> Testing
> -------
> 
> All existing tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message