mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53016: Added test case for ranges value.
Date Sat, 22 Oct 2016 07:13:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53016/#review153638
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53016]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 22, 2016, 3:27 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53016/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2016, 3:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1) New test case for ranges less than or equal to operation.
> 2) Updated `ValuesTest.RangesCoalesceParse` by adding cases
> of sorting ranges.
> 
> 
> Diffs
> -----
> 
>   src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba 
> 
> Diff: https://reviews.apache.org/r/53016/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  --gtest_filter="ValuesTest.RangesLE"
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ValuesTest
> [ RUN      ] ValuesTest.RangesLE
> [       OK ] ValuesTest.RangesLE (0 ms)
> [----------] 1 test from ValuesTest (0 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (15 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="ValuesTest.RangesCoalesceParse"
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ValuesTest
> [ RUN      ] ValuesTest.RangesCoalesceParse
> [       OK ] ValuesTest.RangesCoalesceParse (1 ms)
> [----------] 1 test from ValuesTest (1 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (13 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message