mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53078: Added tests for rlimit isolator.
Date Sat, 22 Oct 2016 06:20:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53078/#review153636
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/posix_rlimit_isolator_tests.cpp (line 98)
<https://reviews.apache.org/r/53078/#comment223046>

    this does not work. of is a directory?


- Jie Yu


On Oct. 20, 2016, 10:38 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53078/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6426
>     https://issues.apache.org/jira/browse/MESOS-6426
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for rlimit isolator.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d 
>   src/tests/containerizer/posix_rlimit_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53078/diff/
> 
> 
> Testing
> -------
> 
> * make check (OS X, clang-trunk w/o optimizations)
> * tested on a number of Linux setups in internal CI
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message