mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
Date Sat, 22 Oct 2016 04:49:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review153521
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp (lines 3864 - 3865)
<https://reviews.apache.org/r/50127/#comment222916>

    ```
    // Make sure the total GPU number detected by allocator is 1
    // which is same as what we set if we do not use auto-discovery. 
    ```



src/tests/containerizer/docker_containerizer_tests.cpp (line 3948)
<https://reviews.apache.org/r/50127/#comment222917>

    s/offers->at(0)/offer



src/tests/containerizer/docker_containerizer_tests.cpp (lines 3953 - 3956)
<https://reviews.apache.org/r/50127/#comment223042>

    What is the use of this?



src/tests/containerizer/docker_containerizer_tests.cpp (line 3989)
<https://reviews.apache.org/r/50127/#comment223041>

    s/first/only one
    
    We have only one GPU for the test.


- Guangya Liu


On 十月 21, 2016, 9:12 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated 十月 21, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a

> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message