mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
Date Sat, 22 Oct 2016 04:24:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/#review153632
-----------------------------------------------------------




src/slave/containerizer/docker.hpp (line 259)
<https://reviews.apache.org/r/50841/#comment223039>

    My previous comments does not contain `on Linux`, this is not needed as this helper is
already protected by `#ifdef __linux__`
    
    ```
    Allocate GPU resources for a specified container.
    ```



src/slave/containerizer/docker.hpp (line 268)
<https://reviews.apache.org/r/50841/#comment223040>

    ```
    // Deallocate GPU resources for a specified container.
    ```


- Guangya Liu


On 十月 21, 2016, 9:10 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50841/
> -----------------------------------------------------------
> 
> (Updated 十月 21, 2016, 9:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added control logic to allocate/deallocate GPUs to GPU-related task
> when the task is started/terminated.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
>   src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 
> 
> Diff: https://reviews.apache.org/r/50841/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message