mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <>
Subject Re: Review Request 51031: Added non-recursive version of `cgroups::get`.
Date Sat, 22 Oct 2016 04:18:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 22, 2016, 4:18 a.m.)

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and Jiang Yan Xu.

Bugs: MESOS-6035

Repository: mesos


In some cases, we just want to get the children cgroups instead of
retrieve descendant cgroups recursively. We added an argument to
`cgroups::get` to indicate whether to retrieve cgroups recursively but
made recursive retrieve the default behaviour. This patch fixed some
incorrect `TEST_CGROUPS_ROOT` checks as well.


  src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
  src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 
  src/tests/containerizer/cgroups_tests.cpp 0afaec6ae948cabf1472bf01103210d8f9809cb1 


Testing (updated)

sudo GLOG_v=1 ./bin/ --gtest_filter="*CGROUPS*" --verbose
sudo GLOG_v=1 ./bin/ --gtest_filter="*Cgroups*" --verbose


haosdent huang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message