mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 53067: Added log message when terminating agent ID.
Date Fri, 21 Oct 2016 21:37:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53067/#review153602
-----------------------------------------------------------




src/slave/slave.cpp (lines 815 - 819)
<https://reviews.apache.org/r/53067/#comment223012>

    don't think you need to do this; `info.id()` will give you the same result.



src/slave/slave.cpp (line 821)
<https://reviews.apache.org/r/53067/#comment223010>

    s/agent ID/agent/


- Vinod Kone


On Oct. 20, 2016, 4:53 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53067/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent ID is terminated (e.g., due to "--recover=cleanup"), it
> seems important to notify the operator that the agent will be assigned a
> new agent ID when it is next started.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 
> 
> Diff: https://reviews.apache.org/r/53067/diff/
> 
> 
> Testing
> -------
> 
> Visual inspection of log output.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message