mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 53035: Tweaked an agent log message.
Date Fri, 21 Oct 2016 21:28:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53035/#review153600
-----------------------------------------------------------




src/slave/slave.cpp (line 937)
<https://reviews.apache.org/r/53035/#comment223006>

    here "register" is used to mean register or re-register. just like #918.


- Vinod Kone


On Oct. 20, 2016, 3:07 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53035/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 3:07 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The previous wording implied the agent was going to "attempt to
> register"; in fact the agent might never attempt to "register" (only
> re-register) depending on its local state.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 
> 
> Diff: https://reviews.apache.org/r/53035/diff/
> 
> 
> Testing
> -------
> 
> Visual inspection of log output.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message