mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <>
Subject Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.
Date Fri, 21 Oct 2016 11:38:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 21, 2016, 11:38 a.m.)

Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, Jie Yu, and
Jiang Yan Xu.


Addressed comments.

Summary (updated)

Cleaned up the way in which the executors load configuration options.

Repository: mesos

Description (updated)

Updated the executors so that they use only `stout::flags` to load
config options.

They used to use a mix of `stout::flags` and `os::getenv`.

Diffs (updated)

  src/CMakeLists.txt e60d34ca4b714bb237d5864b4682280f11b147a6 
  src/ 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d 
  src/common/parse.hpp ee26717ed54445f57fa3a11c74ece8fe0861bd40 
  src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 
  src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
  src/exec/exec.cpp 1dc20390907253a466b7272b7f8b33ea14afb236 
  src/exec/flags.hpp PRE-CREATION 
  src/exec/flags.cpp PRE-CREATION 
  src/executor/executor.cpp 1d47b52d89eedee59d160badd6313d34e3bdb6d2 
  src/executor/flags.hpp PRE-CREATION 
  src/executor/flags.cpp PRE-CREATION 
  src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 
  src/launcher/executor.hpp 217680d99d6e8c31130d7dc714f8cd730f360852 
  src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 
  src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 
  src/tests/containerizer.cpp 69b93c70dc883e1edff3e6c2d7c8da9ef05e42f8 



`make check`


Gastón Kleiman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message