mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52818: Ensured agent is recovered in SlaveEndpointTests.
Date Fri, 21 Oct 2016 09:38:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52818/#review153519
-----------------------------------------------------------



Patch looks great!

Reviews applied: [52818]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 21, 2016, 9:01 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52818/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The tests in this case did either assume that e.g., requests for agent
> endpoints could always reliably be satisfied by a not yet fully
> recovered agent, or did not explicitly observe the recovery and
> instead relied on just settling the clock.
> 
> Make sure agents are actually fully recovered, even if not strictly
> required right now. Also actually observe agent recovery calls like
> done elsewhere.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp 6bd2aa96cb05aa087c0807cc3dd1830451efe106 
> 
> Diff: https://reviews.apache.org/r/52818/diff/
> 
> 
> Testing
> -------
> 
> `make check` (OS X, clang-3.9 w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message