mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
Date Fri, 21 Oct 2016 03:02:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review153492
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines 170 - 174)
<https://reviews.apache.org/r/50947/#comment222861>

    Here should also check if using `mesos` containerizer, otherwise, the `docker` containerizer
will always return here and there may be GPU overcommit if we specify more GPU resources than
the actual GPU resources.
    
    ```
    // Pass the GPU resources through if we're not going to do any
    // isolation for mesos conainerizer or we cannot validate the
    // resources using NVML.
    if ((strings::contains(flags.containerizers, "mesos") &&
         isolators.count("gpu/nvidia") == 0) ||
        !nvml::isAvailable()) {
      return resources;
    }
    ```


- Guangya Liu


On 十月 20, 2016, 10:01 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> -----------------------------------------------------------
> 
> (Updated 十月 20, 2016, 10:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5975
>     https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
> docker and external containerizers do not need it anymore. This removed
> the 'gpu/nvidia' isolator check for docker and external containerizers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65

> 
> Diff: https://reviews.apache.org/r/50947/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message